Modernize CI - #594
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernises the repository’s CI/release workflow and introduces a couple of reusable composite actions, while also pinning the project’s package manager to pnpm 11.
Changes:
- Update CI workflow actions/steps (checkout, pnpm/bun setup, artifact upload/download) and add downstream reusable workflow jobs for SDK builds.
- Add
packageManagerpin and include@actions/artifactas a devDependency for artifact uploads. - Add composite actions for installing OpenAPI Generator and downloading the bundled spec.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
pnpm-lock.yaml |
Lockfile update to include @actions/artifact and its transitive dependencies. |
package.json |
Pins pnpm version and adds @actions/artifact to devDependencies. |
.github/workflows/ci.yaml |
Refactors CI jobs and introduces reusable workflow fan-out for downstream builds. |
.github/actions/setup-generator/action.yml |
New composite action to cache and install a pinned openapi-generator jar. |
.github/actions/download/action.yml |
New composite action to fetch a bundle from artifacts (in-repo) or latest release (external). |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (2)
.github/workflows/ci.yaml:83
pnpm/setup@v2does not exist and the bundle job currently never installs dependencies, sobun --bun run bundleand the subsequentrequire('@actions/artifact')in github-script will fail. Use a valid pnpm setup action and run an install step before bundling/uploading artifacts.
- uses: pnpm/setup@v2
with:
runtime: bun@latest
cache: true
.github/workflows/ci.yaml:155
- The release job uses pnpm (e.g.,
pnpm semver) but the current setup step referencespnpm/setup@v2(nonexistent) and does not ensure a Node version compatible with pnpm 11. Pin Node >=22 and use a valid pnpm setup action so release version computation is reliable.
- uses: pnpm/setup@v2
with:
runtime: bun@latest
cache: true
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
commit: |
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.